search

madmatt / silverstripe-encrypt-at-rest

Encrypt data at rest in your database
7 stars 11 forks source link

Silverstripe 4 compatibility #27

Closed edwilde closed 10 months ago

edwilde commented 1 year ago

Update the module to be compatible with Silverstripe 4.

This branch has been used on numerous production sites already, so seems reliable.

thats4shaw commented 11 months ago

@madmatt any chance we could look at getting this merged?

ssmarco commented 11 months ago

I would love this project to continue forward, let us know if there is anything we can help

madmatt commented 10 months ago

@ssmarco @edwilde I've reviewed this one last time and there's just one super minor tweak to make:

  1. Please fix up the composer.json min-version for silverstripe/framework to be ^4.9.0

I've manually diffed the following files that didn't get marked as a rename and confirmed I'm happy enough with the changes that it doesn't block merging:

  1. code/AtRestCryptoService.php -> src/AtRestCryptoService.php
  2. code/extensions/EncryptDataObjectsFieldExtension.php -> src/Extension/DecryptDataObjectFieldsExtension.php
  3. code/fieldtypes/EncryptedDatetime.php -> src/FieldType/EncryptedDatetime.php
  4. Removal of tests/unit/EncryptedDataObjectTest.php in favour of individual tests for the AtRestCryptoService, the extension and field types.
madmatt commented 10 months ago

Files are marked as "deleted/created", which makes the PR harder to review than necessary.

Per my comment above, this one is okay now, I've manually reviewed the files that weren't correctly marked and can confirm there's nothing bad in there, just updates to method signatures and minor tweaks to how the code works primarily.

madmatt commented 10 months ago

Thanks @edwilde, @Firesphere and everyone else who has contributed to this! Merging this now, and I'll comment again when a new major version is released.