search

madmax3365 / node-red-node-discord

Discord nodes for node-red
6 stars 9 forks source link

Adding trigger for emoji reactions on Discord messages #7

Closed MarkOSullivan94 closed 4 years ago

MarkOSullivan94 commented 4 years ago

Now should be possible to receive a trigger anytime a user adds a reaction to a message on Discord 🎉

Used get-messages as the base for implementing this feature, if there's any way I can improve what I've done, let me know 👍

Also consulted the Discordjs docs to help with implementing this.

madmax3365 commented 4 years ago

Thanks for contribution @MarkOSullivan94 ! I've looked into code and didn't noticed anything dangerous there. Actually I am thinking about tree-shaking and improving output from nodes, leaving there only necessary information.
So, I'm going to merge your PR and release it, In the next version, I'll update dependencies as you suggested in #4 . Thanks again for the contribution!

MarkOSullivan94 commented 4 years ago

Hi @madmax3365 thanks for merging this in!

I've actually been working on a few different features for this repo which you can see in my develop branch: https://github.com/MarkOSullivan94/node-red-node-discord/tree/develop

Would be good to work together on improving the module 👍