search

madmax983 / Lightning-Data-Grid

A data grid for Lightning Component Framework
MIT License
25 stars 13 forks source link

Weird lightning:buttonIcon issue #34

Closed madmax983 closed 6 years ago

madmax983 commented 6 years ago

New issue that has cropped up:

If you toggle a child row, then scroll down and scroll back up, the grid is maintaining the state of the hierarchy as expected. However, the lightning:buttonIcon for chevron right and chevron down get rendered rotated 90 degrees.

This is just cropping up in Winter '18.

madmax983 commented 6 years ago

Looks like SLDS is now auto-rotating the svg icon 90 degrees when aria-expanded gets set to true. This means we can get rid of the If logic blocks displaying chevron right versus chevron down in cell, and just make sure aria-expanded is getting set correctly on click.

madmax983 commented 6 years ago

On the flip side (ha!): it is rotating all svgs in the th cell, so the edit icon is getting flipped as well. Will need to hack out some css to prevent that.