search

madmaxms / iconpack-obsidian

Gnome Icon Pack based upon Faenza, optimized for dark themes
GNU General Public License v3.0
191 stars 29 forks source link

Only inherit themes which are really needed #84

Open alexxcons opened 4 months ago

alexxcons commented 4 months ago

Hi Obsidian team,

now that the related xdg merge request got merged and v0.18 of the spec got released, I am starting my mission to get the "Inherits" attribute right for popular icon-themes to prevent potentially missing icons 🙂

Currently Obsidian has:

Inherits=Ambiant-MATE,Mint-X,Faenza-Dark,KFaenza,gnome,hicolor

I wonder why Ambiant-MATE,Mint-X,Faenza-Dark,KFaenza and gnome are listed here ... is Obsidian lacking fd.org icons which need to be provided by these?

If there is no strong reason to keep them in the Inherits list, I would suggest dropping them.

If one/some of the other themes need to stay on the list for some reason, it makes sense to have a section in the README.md to explain packagers that the obsidian-icon-theme package should have a hard dependency on the other listed themes.