madmicio / LG-WebOS-Remote-Control

Remote Control for LG TV WebOS
392 stars 74 forks source link

After latest update lg-remote-control custom card not showing anymore #130

Closed MEKadan closed 6 months ago

MEKadan commented 7 months ago

This has been working OK until yesterday, now I get this:

image

Where should I start looking for problam?

MEKadan commented 7 months ago

Hmm.. There was an older thread started 3 weeks ago describing the same problem: https://github.com/madmicio/LG-WebOS-Remote-Control/issues/126

Because the error occurred only after yesterday I thought it would be different case, however, the fix mentioned there,, editing the resource string worked.

The resource string should be:

/hacsfiles/LG-WebOS-Remote-Control/lg-remote-control.js?hacstag=25700599020

EDIT: After the fix the controller image shows as before and everything works,, however, HACS is still announcing error:

image

And it is pinpointed to be this module:

image

Tried also the resource string without ?hacstag=25700599020in the end, no change

Probably a bug of some sort, but does not seem to affect to operation, at least at the time being

gregorasia commented 7 months ago

This has been working OK until yesterday, now I get this:

image

Where should I start looking for problam?

It's exactly the same for me.

It worked: https://github.com/madmicio/LG-WebOS-Remote-Control/issues/126#issuecomment-1811030188

flyman1664 commented 7 months ago

Same issue on my side. Card is working. However error is present in HACS

image

Clam58 commented 7 months ago

If you update to version 2.0.1 the resource resets to null, so you need to manual re-edit to fix. Hopefully @madmicio can fix this in due course.

MEKadan commented 7 months ago

If you update to version 2.0.1 the resource resets to null, so you need to manual re-edit to fix. Hopefully @madmicio can fix this in due course.

The point is, that it still shows the error even after manually updating the resource string. The module works, though.

twanjaarsveld commented 7 months ago

having the same error will try the resource fix

Custom element doesn't exist: lg-remote-control.
type: custom:lg-remote-control
entity: media_player.lg_tv_webos
hunorbatori commented 7 months ago

If you update to version 2.0.1 the resource resets to null, so you need to manual re-edit to fix. Hopefully @madmicio can fix this in due course.

The point is, that it still shows the error even after manually updating the resource string. The module works, though.

I guess because HACS for some reason thinks the path should be /hacsfiles/LG-WebOS-Remote-Control/**null**?hacstag=257005990201 instead of /hacsfiles/LG-WebOS-Remote-Control/lg-remote-control.js?hacstag=257005990201 so it shows the error.

I think after the manual edit, the HACS error message safely can be ignored while the issue is not fixed.

PhilippeP62 commented 7 months ago

Same problem , same fix (thanks) , same result

rozPierog commented 7 months ago

I had to change resource path to lg remote inside http://homeassistant.local:<port>/config/lovelace/resources to the one provided here https://github.com/madmicio/LG-WebOS-Remote-Control#hacs-card-install

CarlesLlobet commented 7 months ago

+1 ! Same problem, same "fix" (workaround), same result.

Looks like HACS is not finding the js file properly (hence the "null")? Maybe something related to a HACS update on their syntax for modules?

May this commit be the culprit? 🤔 @cstosgale Not entirely sure what it was trying to fix (HACS install always worked for me), but removing the "content in root" makes HACS blind to "where" he can find the provided filename, hence the null. If content in root is false, it assumes its in a subdirectory, but this integration has no subdirectory for the js.

cstosgale commented 6 months ago

I was attempting to fix exactly this issue by removing that line, as I thought it worked the opposite way round. I've been having this issue since before that commit, but it doesn't seem to have made any difference

CarlesLlobet commented 6 months ago

Oh I see @cstosgale. Apologies. Actually although it should not (and does not) make any difference according to the docs, your attempt was quite good since I've been checking many other integrations I use such as Transmission-card, Alarmo-card, or mini-graph-card and none of them specify "content_in_root", so that line could have been causing some undocumented bug. Sadly seems not the case.

I've been trying to review commits before that to see if anything could have affected the HACS install but I haven't been able to find anything else (don't know this integration's code that well).

Let's pray you guys can find it eventually 🙏

LordMrcS commented 6 months ago

downgrading to 1.1.3 seems easier and that fixed it for now to me. (tried 2.0, no luck there aswell)