madminer-tool / madminer-workflow

Madminer complete cloud-based analysis
MIT License
4 stars 4 forks source link

Code refactor (All) #12

Closed Sinclert closed 4 years ago

Sinclert commented 4 years ago

This PR refactor the Python code for the "All" use-case (docker-images-all/code).


In this case, a different approach has been followed:

Given that the "all" use case is nothing else but the combination of "physics" and "ml" use cases, all the Python source files are practically equal. [1]

Now, instead of having a similar copy of the Python files from docker-madminer-ml/code and docker-madminer-physics/code into the version control, I have defined a new Makefile rule (copy), to copy all the source files into a folder next to the docker-madminer-all/Dockerfile.

In addition, the file with the copied Python files has been added to the .gitignore.


Notes:

[1]: The files are not exactly equal. The difference relies on the use of /home/... instead of /madminer/... absolute path when saving and loading files. This difference is not important anymore, due to the introduction of relative paths throughout the refactors (https://github.com/scailfin/workflow-madminer/pull/10, https://github.com/scailfin/workflow-madminer/pull/11).