search

madminer-tool / madminer-workflow

Madminer complete cloud-based analysis
MIT License
4 stars 4 forks source link

Fix Delphes non-'sm' execution #16

Closed Sinclert closed 4 years ago

Sinclert commented 4 years ago

This PR aims to continue the fixes from previous PR (https://github.com/scailfin/workflow-madminer/pull/15), that allowed all the Pyshics use-case steps to be run locally.

For now, the ROOT_INCLUDE_PATH Delphes run-time used environment variable has been added. When not defined, the beginning of the log file (log_delphes.log) that the 4th step of the Physics workflow creates, look like this:

Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootTreeReader.h
   requested to autoload type ExRootTreeReader
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootTreeWriter.h
   requested to autoload type ExRootTreeWriter
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootTreeBranch.h
   requested to autoload type ExRootTreeBranch
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootResult.h
   requested to autoload type ExRootResult
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootClassifier.h
   requested to autoload type ExRootClassifier
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootFilter.h
   requested to autoload type ExRootFilter
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootProgressBar.h
   requested to autoload type ExRootProgressBar
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootConfReader.h
   requested to autoload type ExRootConfParam
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootConfReader.h
   requested to autoload type ExRootConfReader
Error in cling::AutoloadingVisitor::InsertIntoAutoloadingState:
   Missing FileEntry for ExRootAnalysis/ExRootTask.h
   requested to autoload type ExRootTask
** INFO: adding module        ParticlePropagator       ParticlePropagator       
** INFO: adding module        Efficiency               ChargedHadronTrackingEfficiency
... From this point forward modules are loaded normally ...

The reference to solve this problem has been obtaine from this ROOT forum response.

~What is missing in this PR?~

~Last thing I would like to debug before merging, is the fact that the Physics 4th step (executable via the 4_delphes.sh script), only works when the provided benchmark is sm.~

Additional changes

In order to make the 4_delphes.sh script work with any benchmark, the /extract folder need to be cleanup after each run. This is an issue when running all the benchmark-dependent Delphes steps locally, but not when running them on completely isolated environments (REANA).

Furthermore, I have implemented a "events file discovery snippet" to work with different named output files from the previous step (step 3: Pythia simulation).

I could not figure out why this is happening, so event files will look like:

Sinclert commented 4 years ago

@irinaespejo this PR is not in "draft" stage anymore.

Changes to make it promote to production-ready PR can be checked in these commits:

irinaespejo commented 4 years ago

Thank you @Sinclert the changes look great!