madminer-tool / madminer-workflow

Madminer complete cloud-based analysis
MIT License
4 stars 4 forks source link

Parametrized output folder #27

Closed Sinclert closed 4 years ago

Sinclert commented 4 years ago

Problem

One of the issues that is interfering with the next goals that this project repository needs to achieve:

is the writing of workflow output files in the same directory as static code and scripts. This causes problems because:

Proposed solution

Thanks to the definition of an intermediate shell-script layer between the workflow specification and the Python code, the output folder is now parametrizable.

This PR introduces a new argument (-o) to all the scripts (both in docker-madminer-ml and docker-madminer-physics folders), which is used as the path to store files.

Other additions:

The definition of initdir and rootdir was only possible after a private conversation with @lukasheinrich, as they were not explained in the Official Yadage documentation (will they soon be? 🤷‍♂️ )

irinaespejo commented 4 years ago

Thank you @Sinclert , this is the PR we talked about over a private Zoom meeting. I tested it locally and works smoothly until the Pythia step. I think we can proceed with the merge. Thank you this is a crucial PR!