generalize plotting step for all methods

madminer-tool / madminer-workflow

Madminer complete cloud-based analysis

MIT License

4 stars 4 forks source link

generalize plotting step for all methods #45

Closed irinaespejo closed 3 years ago

irinaespejo commented 3 years ago

This PR solves the hardcoding present in the last step of the ML wflow plotting. Changes have been made in the files:

madminer-workflow-ml/code/plotting.py
VERSION is now 0.3.1
Update the image tag used in madminer-workflow-ml/workflow/yadage/steps.yml to new VERSION
Added a new input_carl.yml for the ML workflow to test the generalization changes.

If one wishes to use input_carl.yml for the ML step instead of the deafult input.yml then change this line.

irinaespejo commented 3 years ago

Hey @Sinclert could you double-check I didn't mess up something? Thank you!

Sinclert commented 3 years ago

Hi @irinaespejo ,

The madminer-workflow-ml folder is just a GIT submodule being referenced by this repository (its parent). PRs changing submodule contents must be done within the child repositories themselves (in this case, Scailfin/madminer-workflow-ml). Otherwise, you are only changing the submodule reference, and not the real files.

I will close this PR. Please, open a similar one on the child repository. I will add some comments on there.