madmonkey1907 / hakchi

GNU General Public License v3.0
144 stars 36 forks source link

'error.h' file not found on macOS #49

Open paraita opened 6 years ago

paraita commented 6 years ago

Project won't build on my Mac (High Sierra 10.13.4)

hakchi/sntool on  master [!] took 5s
⇣7% ➜ make clean all
clean
crc32.o
clang: warning: -Wl,--gc-sections: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -Wl,--as-needed: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: optimization flag '-fwhole-program' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-fuse-linker-plugin' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-falign-functions=1' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-falign-jumps=1' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-falign-loops=1' is not supported [-Wignored-optimization-argument]
sntool.o
clang: warning: -Wl,--gc-sections: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: -Wl,--as-needed: 'linker' input unused [-Wunused-command-line-argument]
clang: warning: optimization flag '-fwhole-program' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-fuse-linker-plugin' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-falign-functions=1' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-falign-jumps=1' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-falign-loops=1' is not supported [-Wignored-optimization-argument]
sntool.cpp:11:10: fatal error: 'error.h' file not found
#include <error.h>
         ^~~~~~~~~
1 error generated.
make: *** [sntool.o] Error 1

hakchi/sntool on  master [!?] took 20s
⇣7% ➜

I've removed the flto flag as it was preventing compilation. Any idea ?

paraita commented 6 years ago

so I ended up removing this error.hreference, apparently it doesn't exist on MacOS, the equivalent is mach/error.h, I replaced the error() call in sunxi_flash_ioctl() by another error_printf() call instead. I had to make some flag changes elsewhere to make the build complete successfully. I can submit a PR if you'd like