search

madnificent / ember-mode

Emacs mode for navigating through emberjs projects.
MIT License
32 stars 8 forks source link

add autoload cookie and fix bindings for build/serve/test #6

Closed jesse-black closed 9 years ago

jesse-black commented 9 years ago

also submitted a PR to melpa here

jesse-black commented 9 years ago

I've fixed most of the things discussed at the melpa pr. For the keybindings, the conventions say not to define C-c letter bindings because they are reserved for users, and that minor modes can use C-c punctuation bindings. How about C-c .?

madnificent commented 9 years ago

Are you picking C-c . for a particular reason? I may be missing the point. It would work for me, though perhaps it's easier to remember C-c e.

Do you know of any libraries that break with C-c e?

jesse-black commented 9 years ago

from the keybinding conventions link:

Don't define C-c letter as a key in Lisp programs. Sequences consisting of C-c and a letter (either upper or lower case) are reserved for users; they are the only sequences reserved for users, so do not block them.

Sequences consisting of C-c followed by any other punctuation character are allocated for minor modes.

So users are supposed to be able to create bindings like C-c c or C-c e in their configuration files and this would overwrite that. This is a minor mode and . is punctuation, so an appropriate keybinding might be C-c .. This actually did happen to me, I was using C-c c in my configuration when I started using this and it would get overwritten.

It will be easy to configure it back to your preferred keybinding anyway.

madnificent commented 9 years ago

Makes perfect sense. Seems I missed the link you included earlier. Thanks.

jesse-black commented 9 years ago

Great! I hadn't changed the keybinding yet, should I make another pr or will you do it?

madnificent commented 9 years ago

I'm on it.