madnificent / ember-mode

Emacs mode for navigating through emberjs projects.
MIT License
32 stars 8 forks source link

Symbol's function definition is void: third #9

Closed flyrev closed 8 years ago

flyrev commented 8 years ago

Hi

I'm using GNU Emacs 24.5.1 (Mac), and I have the following .emacs:

(load "web-mode.el")
(require 'web-mode)

(load "ember-mode.el")
(require 'ember-mode)

(add-to-list 'auto-mode-alist '("\\.phtml\\'" . web-mode))
(add-to-list 'auto-mode-alist '("\\.tpl\\.php\\'" . web-mode))
(add-to-list 'auto-mode-alist '("\\.[agj]sp\\'" . web-mode))
(add-to-list 'auto-mode-alist '("\\.as[cp]x\\'" . web-mode))
(add-to-list 'auto-mode-alist '("\\.erb\\'" . web-mode))
(add-to-list 'auto-mode-alist '("\\.mustache\\'" . web-mode))
(add-to-list 'auto-mode-alist '("\\.djhtml\\'" . web-mode))
(add-to-list 'auto-mode-alist '("\\.hbs\\'" . web-mode))

(add-hook 'js-mode-hook (lambda () (ember-mode t)))
(add-hook 'web-mode-hook (lambda () (ember-mode t)))

Then, when opening a .hbs file and trying to do ember-open-controller, I get

Symbol's function definition is void: third

The emacs mode is displayed as (Web [EM]).

madnificent commented 8 years ago

Looks a lot like we're missing a dependency on Common Lisp support for Emacs. I think the package is named cl. You can try and see whether installing that solves your immediate problem. I'll update the dependencies soon. On Tue 19 Jan 2016 at 09:44, Christian Jonassen notifications@github.com wrote:

Hi

I'm using GNU Emacs 24.5.1 (Mac), and I have the following .emacs:

(load "web-mode.el") (require 'web-mode)

(load "ember-mode.el") (require 'ember-mode)

(add-to-list 'auto-mode-alist '(".phtml\'" . web-mode)) (add-to-list 'auto-mode-alist '(".tpl.php\'" . web-mode)) (add-to-list 'auto-mode-alist '(".[agj]sp\'" . web-mode)) (add-to-list 'auto-mode-alist '(".as[cp]x\'" . web-mode)) (add-to-list 'auto-mode-alist '(".erb\'" . web-mode)) (add-to-list 'auto-mode-alist '(".mustache\'" . web-mode)) (add-to-list 'auto-mode-alist '(".djhtml\'" . web-mode)) (add-to-list 'auto-mode-alist '(".hbs\'" . web-mode))

(add-hook 'js-mode-hook (lambda () (ember-mode t))) (add-hook 'web-mode-hook (lambda () (ember-mode t)))

Then, when opening a .hbs file and trying to do ember-open-controller, I get

Symbol's function definition is void: third

The emacs mode is displayed as (Web [EM]).

— Reply to this email directly or view it on GitHub https://github.com/madnificent/ember-mode/issues/9.

flyrev commented 8 years ago

Adding

(require 'cl)

seemed to help.

madnificent commented 8 years ago

@jesse-black We have a dependency on, and require, cl-lib. Should that be cl instead?

jesse-black commented 8 years ago

cl is deprecated because the functions are un-namespaced, cl-lib has the same functions with cl- namespace, try changing it to cl-third

madnificent commented 8 years ago

Should be fixed in the current release. Can you check, or should I close?

flyrev commented 8 years ago

Removed (require 'cl) from my .emacs and downloaded the latest ember-mode.el. No errors. :)

madnificent commented 8 years ago

Thank you! Sorry it took so long to make these minor change.