search

madnight / githut

Github Language Statistics
https://madnight.github.io/githut
GNU Affero General Public License v3.0
967 stars 125 forks source link

Vim Script and Vim script should be combined #115

Open louwers opened 7 months ago

madnight commented 7 months ago

I see, thanks for reporting, will be fixed soon.

madnight commented 7 months ago

I added a fix that filters the lowercase "Vim script" and leaves "Vim Script." I think "Vim Script" is the official name on GitHub, and I'm not sure why there is also a lowercase variant in the GitHub BigQuery Dataset. Currently, I do not have enough credits/dollars left to rerun the entire history with a proper merge in SQL. Therefore, I filtered out the lowercase naming, which also has a significantly lower count of events.

louwers commented 7 months ago

The official name is "Vim script" as per the manual.

image

And Wikipedia: https://en.wikipedia.org/wiki/Vim_(text_editor)#Vim_script

If you ever do a re-run, I would change it to that.

I would not filter out "Vim script", because this results in an inaccurate comparison of languages. Having a duplicate is preferable to this in my opinion.

madnight commented 7 months ago

You are right, but I referred to the "official name on GitHub". For instance if you open one of the most popular Vim script projects on GitHub and look at the language name https://github.com/tpope/vim-fugitive it will read "Vim Script".

louwers commented 7 months ago

Ah right, so maybe we should file a bug report with GitHub.