Properly parse underscores

madpah / requirements-parser

A Pip requirements file parser.

https://requirements-parser.readthedocs.io

Apache License 2.0

125 stars 41 forks source link

Properly parse underscores #17

Closed saschpe closed 11 years ago

saschpe commented 11 years ago

pkg_resources.Requirement's constructor calls save_name() on the project_name member which converts underscores to hyphens. Thus use Requirement.unsafe_name (the pristine name) instead.

coveralls commented 11 years ago

Coverage remained the same when pulling 6403d5145f1ad7b3705a624b614900eace5433eb on saschpe:master-underscores into 7b0cc239db30581809e081071b6945d63980173c on davidfischer:master.

davidfischer commented 11 years ago

Great catch!

saschpe commented 11 years ago

I guess that's why people dislike it sometimes, setuptools moves in mysterious ways :-)