Fix vcs urls parsing with extras_require

madpah / requirements-parser

A Pip requirements file parser.

https://requirements-parser.readthedocs.io

Apache License 2.0

125 stars 41 forks source link

Fix vcs urls parsing with extras_require #30

Closed ticosax closed 7 years ago

ticosax commented 7 years ago

Make sure extras are correctly parsed in vcs like urls git+https://git.myproject.org/MyProject.git@v0.1#egg=MyProject[security]

On top of #29 and #28 .This pull request needs to be rebased, once they are merged (I hope so).

coveralls commented 7 years ago

Coverage increased (+0.1%) to 98.16% when pulling 279b82e47f7f51fc089cc18e3a7ca3e69c7f9a06 on ticosax:fix-vcs-extras_require into e35b9f70de74251e16f76305d006eca63abcb086 on davidfischer:master.

coveralls commented 7 years ago

Changes Unknown when pulling cab9ebdb834498791368dc3d86b9eef4eacf4f47 on ticosax:fix-vcs-extras_require into on davidfischer:master.

coveralls commented 7 years ago

Changes Unknown when pulling cab9ebdb834498791368dc3d86b9eef4eacf4f47 on ticosax:fix-vcs-extras_require into on davidfischer:master.

ticosax commented 7 years ago

Gentle ping here, to check if you noticed I updated the PR. Have a good day.

davidfischer commented 7 years ago

Thanks for the ping. I'll try to take a look in the next day or two.

kennethreitz commented 7 years ago

Let's get this merged!

davidfischer commented 7 years ago

This looks good. Thanks for making the changes.

My merging is only two months late. 💥