support subdirectory fragments

madpah / requirements-parser

A Pip requirements file parser.

https://requirements-parser.readthedocs.io

Apache License 2.0

125 stars 41 forks source link

support subdirectory fragments #32

Closed sbidoul closed 7 years ago

sbidoul commented 7 years ago

based on #31 to have a green build

coveralls commented 7 years ago

Changes Unknown when pulling fd2c09861512b1232d4af723db36c1f4be038be9 on sbidoul:subdirectory-sbi into on davidfischer:master.

kennethreitz commented 7 years ago

✨🍰✨

kennethreitz commented 7 years ago

Pipenv needs this.

davidfischer commented 7 years ago

I had no idea pipenv used this package. We should probably get some more active maintainers if it is going to be relied on from high visibility packages.

With that said, I'm happy to try to get this in today.

kennethreitz commented 7 years ago

\o/

kennethreitz commented 7 years ago

we'll be happy to help maintain, if needed

davidfischer commented 7 years ago

Back when I first built this module, I don't remember this in the requirement file format. It's there now! I wonder when that got added?

Just for reference in the PR, this PR allows parsing lines like:

-e vcs+protocol://repo_url/#egg=pkg&subdirectory=pkg_dir

davidfischer commented 7 years ago

This looks good and I went ahead and merged it! :ship:

To further the discussion around maintainers, this project is actively seeking maintainers (per the project tagline). I'm not currently using this project for anything. If you guys are, it's probably best if one or both of you took over some of the maintenance. I don't want to be a roadblock to another project and I'd be happy to see this get new life as a building block of something cool like pipenv. As they say, the last job of an open source maintainer is to find the next maintainer.

Long story short, are either of you guys interested in becoming collaborators? I figure that's a decent first step.

kennethreitz commented 7 years ago

/cc @nateprewitt @techalchemy @erinxocon

kennethreitz commented 7 years ago

@sbidoul can you add support for this to pipenv?

sbidoul commented 7 years ago

@davidfischer I can't guarantee much in terms of availability, but I'm happy to do some code review so feel free to add me as collaborator.

sbidoul commented 7 years ago

can you add support for this to pipenv?

https://github.com/kennethreitz/pipenv/pull/507