madpah / requirements-parser

A Pip requirements file parser.
https://requirements-parser.readthedocs.io
Apache License 2.0
125 stars 41 forks source link

`setuptools` required @ runtime #37

Closed cooperlees closed 6 years ago

cooperlees commented 6 years ago

Can we add install_requires 'setuptools' as in some use cases I need to be explicit to have setuptools available.

Happy to do the PR.

cooperlees commented 6 years ago

https://github.com/davidfischer/requirements-parser/pull/38

ambv commented 6 years ago

Cooper is right, requirement.py imports from pkg_resources so setuptools should be listed as a hard dep of requirements-parser.

cooperlees commented 6 years ago

Fix is merged! Thanks. Should we bump a version and send to PyPI (you prob want to address the other PRs I guess too).

cooperlees commented 6 years ago

The fix has been merged.