madpilot / hass-amber-electric

Home Assistant Component to pull the latest energy prices from Amber Electric
MIT License
26 stars 1 forks source link

Adding support for HACS #14

Closed troykelly closed 3 years ago

troykelly commented 3 years ago

Will need to be compliant with the HACS rules before listing - but at least people can use HACS to install from the repo.

bjeanes commented 3 years ago

Huh weird. I was able to install it with HACS prior to this (after adding this repo to HACS as a custom repo). Do I have to do anything special to switch to the official HACS distribution?

madpilot commented 3 years ago

No idea - I've never used HACS. @troykelly ?

troykelly commented 3 years ago

tl;dr You shouldn't need to change anything @bjeanes

longer version: Once I get a chance to fix the missing brand, @madpilot can request listing in HACS to make it easier (or not - totally up to them!) HACS's "listed" repositories are really just references to the repos so you don't have to add them manually. I'm surprised you could just add the repo without the hacs.json - maybe custom repo's are a little more forgiving?

madpilot commented 3 years ago

The brand stuff is fixed. Last error is "The repository is missing topics" - https://github.com/madpilot/hass-amber-electric/runs/3067287117 - which I don't know how to fix

troykelly commented 3 years ago

The brand stuff is fixed. Last error is "The repository is missing topics" - https://github.com/madpilot/hass-amber-electric/runs/3067287117 - which I don't know how to fix

@madpilot That one is tucked away here. You sort of need a Rosetta Stone to work out some HA stuff.

madpilot commented 3 years ago

Ok, we are green: https://github.com/madpilot/hass-amber-electric/runs/3074022114

How do I request a HACs listing?

troykelly commented 3 years ago

I had to remove mine, so I've added yours here. If it gets rejected for trying to do two things at once - the instructions are here.

madpilot commented 3 years ago

Cool - can't do it now, will try tonight or in the morning

troykelly commented 3 years ago

Turns out I can't do it - I'm not a major contributor Error: 'troykelly' is not a major contributor to 'madpilot/hass-amber-electric'

You will need to add to the appropriate spot in integration

  "madpilot/hass-amber-electric",
madpilot commented 3 years ago

Done. Waiting for approval