search

madprops / grasshopper

Advanced Tab Manager For Firefox
https://addons.mozilla.org/firefox/addon/grasshopper-urls/
GNU General Public License v3.0
50 stars 2 forks source link

Sticky filter search bug in combination with auto restore #103

Closed N3C2L closed 3 months ago

N3C2L commented 3 months ago

Please activate these settings:

  1. filter > sticky filter > activate

  2. general > auto restore > on action

  3. do a tab search > problem: displaying only 1 letter then it deletes 1 letter afterwards

  4. another bug with sticky filter activated: set auto restore to "never" or any other auto restore activation option by seconds (1-30).

  5. search at least 5 different tab names > problem: often tabs will be auto activated only by typing letters in the search bar (mostly after typing 4-5 letter of the tabs name)

madprops commented 3 months ago

@N3C2L can you remind me what sticky filters do? I don't use it and I don't remember exactly what it was supposed to solve.

Edit: But I did find some buggy behavior on auto restore. Edit: And I'm noticing sticky filter activate is activating tabs automatically upon filter search. Edit: Sticky filter is now causing another problem. I think I'm gonna remove it.

madprops commented 3 months ago

I have removed the sticky filter code. It was causing several problems and complicating things.

Edit: I'll see if I can fix it instead.

Ok I now see what's sticky about it. It works on the individual item I thought it worked on multiple items.

N3C2L commented 3 months ago

Yeah, sorry for late reply I was away after posting this issue. we discussed it here: https://github.com/madprops/grasshopper/discussions/51#discussioncomment-7663959 It would be cool if you can fix it instead of removing it.

madprops commented 3 months ago

Alright I uploaded some fixes regarding auto-restore and sticky filters. Let me know if things work properly now.

madprops commented 3 months ago

Uploaded again. The most recent version is v2812

N3C2L commented 3 months ago

Thanks! Search is fine now with sticky filters activated!

However I think something else is now going on when auto-restore is "on action":

You can't trigger a double click action with the mouse anymore: it's flashing when double clicking an item: for example try it with "edit title" as a command for double click.

N3C2L commented 3 months ago

Another thing:

I have pins set to "hidden" because I just want to see them in the tab box. However if I am doing a search now, I can't search the hidden pins. Do you think you can make them visible when doing a search, and hide them again when no search is active?

madprops commented 3 months ago

On Action should work now.

And Pins now get visible on text filter or on Pins filter mode.

N3C2L commented 3 months ago

Thanks a bunch for these fixes! 👍 I think I can close this issue.