search

madprops / grasshopper

Advanced Tab Manager For Firefox
https://addons.mozilla.org/firefox/addon/grasshopper-urls/
GNU General Public License v3.0
55 stars 2 forks source link

Renaming Subheader and Combo #161

Closed N3C2L closed 1 week ago

N3C2L commented 1 week ago

I have a small problem with combos and it would be nice if you could take a look at it:

I want to create a combo consisting of the following commands:

  1. Insert Subheader
  2. Esc Key (to escape the naming popup)
  3. Apply a template that will give this subheader a preset title and a preset icon

Result: It's not possible with this method, because after subheader creation, the tab below will get activated.

So I tried it with another combo (same as above but with a change):

  1. Insert Subheader
  2. Esc Key (to escape the naming popup)
  3. Subheader up (to switch to the created subheader)
  4. Apply a template that will give this subheader a preset title and a preset icon
  5. Edit title (I would like to refine the name manually afterwards here)

Result: This works, but the problem with this combo is that the "subheader up" command in this combo is disturbing the prompt of the "edit title" command in this combo. I don't know why, but the keyboard input is lost in this "edit title" dialog when the "subheader up" command in this combo runs before. You can try it yourself by putting these two into a combo and try to type right away with the keyboard after the dialog appears. In my case I need to click into this keyboard input field with the mouse first to edit the title.

madprops commented 1 week ago

I tried the second combo

(I'm surprised to see it work)

And yes, I guess it's a browser limitation, because the focus method does get called. Not sure there's something I can do unfortunately.

userinta

N3C2L commented 1 week ago

Ok, thanks for checking. Can you please try to modify the subheader creation; that on subheader creation the tab below won't get activated (the subheader should get activated instead). And then try this new subheader creation with the "edit title" in a combo together. Is this working then with the input field or is it the same problem?

madprops commented 1 week ago

Just tried that, thought it would work, but it didn't. The action is too indirect I guess.

Oh wait...

Yeah it doesn't work. Focusing the header actually messes the edit focus further.

N3C2L commented 1 week ago

Thanks for trying. It's not a big problem. I could double click the tab anyway after that, because that's triggering "edit title" cmd on the tab. I guess a "double mouse click" cmd in the end of a combo wouldn't make a differerence here? It would be too indirect either? Edit: I can test it with middle click instead.. Ok tested it with middle click, it's the same problem, no input. But it's not a big deal since I can double click the tab after this combo, no problem. I can close this, I think.