madprops / grasshopper

Advanced Tab Manager For Firefox
https://addons.mozilla.org/firefox/addon/grasshopper-urls/
GNU General Public License v3.0
50 stars 2 forks source link

reuse filter #79

Closed N3C2L closed 10 months ago

N3C2L commented 10 months ago

I think there is a bug when reuse filter is enabled. When typed into the search bar and then switching to filter red, the search bar is blank again. Another observation: If I am in an active filtering view, like color red, and then use the custom filter cmd: Shouldn't the custom filter be inserted in the search bar of the active filtering view (color red) instead of switching to "All" view and searching there?

madprops commented 10 months ago

Good observations. Both points are now fixed in v2164.

N3C2L commented 10 months ago

Thanks a lot for fixing!

Another bug: ctrl+v does not work in the search bar.

May I suggest this enhancement for the search bar: when right clicking in the search bar: copy text / paste text.

If you click on a tab an run the "filter domain" cmd, shouldn't this new filtered domain be added to the list in the "filter history"?

madprops commented 10 months ago

Changed the filter context menu. It saves more filters now. Added Copy, Paste, and Clear. Removed ctrl+c and ctrl+v shortcuts entirely so they can be used freely.

N3C2L commented 10 months ago

Thank you! Just a little thing: If the filter history is empty and you run the filter history cmd, there should be a popup informing that the filter history is empty. Else nothing appears when this cmd is executed.

madprops commented 10 months ago

Replaced the command with Filter Context

N3C2L commented 10 months ago

I discovered this issue: The reuse filter does work with the buttons on top, but does not work if you switch the mode with the cmds "show history", "show bookmarks" and "show tabs".

madprops commented 10 months ago

I'll fix.