madridccppug / meetups

Slides, presentations, videos,... all the material from meetups
https://madridccppug.github.io/meetups/
2 stars 7 forks source link

Bad position of "play" icon #22

Closed jgsogo closed 5 years ago

jgsogo commented 5 years ago

After merging #20 now we have a link to the Youtube video, but... it may need some CSS to position it.

image

newlawrence commented 5 years ago

Well... I think I should have paid more attention to that. The problem is related to the Youtube badge I chose to use, which I picked it from this project because I dind't wanted to start bloating the repository with external branding stuff. Now, I'm making some tests with the icons provided by Youtube itself and they seem to work better.

The question is, in which order do you think it is better to put the icon?

Afterwards? afterwards

Beforewards? beforewards

In my honest opinion, I think afterwards looks prettier than beforewards; but I don't mind it which one to use at last. Also, I think the red color is more effective than the black one for the icon.

jgsogo commented 5 years ago

I prefer it afterward, and if possible I will fix the vertical alignment (and more horizontal space)...

Maybe it is better to put it in another section after contents

Contents:
 * bla
 * bla
 * bla

Links: [youtube] [...]
newlawrence commented 5 years ago

What about this?

capture

In the future we can use that section to refer to other social media or other social networks (like including a direct link to the old meetup event and so on).

jgsogo commented 5 years ago

Maybe a little bit smaller, but don't worry about it too much, we can change it in the future

newlawrence commented 5 years ago

What do you think about this?

jgsogo commented 5 years ago

Nice! but now that I see it I wouldn't use a section, just a line: "Related content: ", don't you think it is too much having a section?

newlawrence commented 5 years ago

Well, the problem again with using only a line is the alignment of the icons. In the last try, which you can see above, the icons align with the base line of the text. I'll give this another try and see the results.