Dark theme custom colors don't render.

madrilene / eleventy-excellent

Eleventy starter based on the workflow suggested by Andy Bell's buildexcellentwebsit.es.

https://eleventy-excellent.netlify.app/

Other

382 stars 69 forks source link

Dark theme custom colors don't render. #41

Closed Midknight closed 6 months ago

Midknight commented 6 months ago

While working with this template I found that iOS Safari or Firefox do not render the custom color variables while in the dark theme appropriately. I have looked on the demo site as it also shows this issue. I am trying to track down what might be causing it but thought to bring it up.

Screenshot of iPhone with Firefox iOS.

iPhone-FirefoxiOS

madrilene commented 6 months ago

Hi, thanks! I tend to skip testing that system. Should be fixed now for Safari / iOS (so, also for Firefox and Chrome).

https://github.com/madrilene/eleventy-excellent/blob/main/src/assets/css/global/variables.css

Midknight commented 6 months ago

Thank you! Ok I see now what you were pushing for with HSL (types: : hsl() (HSL color model): Mix and in parameters

Was missing that as I was like there shouldn't be any issues here.