madrilene / eleventy-excellent

Eleventy starter based on the workflow suggested by Andy Bell's buildexcellentwebsit.es.
https://eleventy-excellent.netlify.app/
Other
398 stars 71 forks source link

Latest Release Fails to Build #59

Closed beartrack closed 1 month ago

beartrack commented 1 month ago

Hi,

First, thanks for this incredible project!

You may be aware, as it was mentioned as a potentially breaking change, but I am unable to build the latest release using Node 22.8.

[11ty] Problem writing Eleventy templates:
[11ty] 1. Having trouble writing to "./dist/blog/index.html", "./dist/blog/page-2/index.html" from "./src/pages/blog.njk" (via EleventyTemplateError)
[11ty] 2. Transform `html-minify` encountered an error when transforming ./src/pages/blog.njk. (via EleventyTransformError)
[11ty] 3. Parse Error: <nav
[11ty]   id="mainnav"
[11ty]   class="mainnav
[11ty]   aria-label="Main"
[11ty] >

Reverting to commit ca95055 fixes this issue.

madrilene commented 1 month ago

Can I have a look in your repo?

beartrack commented 1 month ago

Hey! Thanks for looking into this. I was actually setting this up for a new project, so I have not uploaded it to GitHub yet. I can if it would be helpful though.

I did just attempt to reproduce this in a clean dev environment and had the same result. macOS 15 + Node 22.9. Steps I took:

git clone https://github.com/madrilene/eleventy-excellent.git 11ty cd 11ty npm install npm run build

And I get the exact same error as my original post.

If I run git checkout ca95055 and then npm run build again, it builds correctly.

madrilene commented 1 month ago

There was an unclosed class attribute! Should be fixed now! https://github.com/madrilene/eleventy-excellent/commit/cc642abddad65a8c4257625069ec0d0121e84cac

beartrack commented 1 month ago

That did the trick! Thanks

Sorry for raising such a simple issue. I initially thought one my customizations broke something, so I was taken by surprise when starting over with a new git clone also failed to build.

madrilene commented 1 month ago

Not at all, thank you for making me aware!