search

madrilene / eleventy-excellent

Eleventy starter based on the workflow suggested by Andy Bell's buildexcellentwebsit.es.
https://eleventy-excellent.netlify.app/
Other
382 stars 69 forks source link

Remove autofocus from click handling #9

Closed deniseileen closed 1 year ago

deniseileen commented 1 year ago

Hi @madrilene, I have started using your template and really enjoy the setup. Thank you for sharing it.

I noticed an issue on mobile where any click outside the menu causes a re-focus on the menu button. This issue came up when I added a netlify form to my site, and the autofocus prevented users from entering information on mobile.

I don't see a need to have the autofocus, and the problem it causes seems to be worse than the benefit it provides. However, I could be missing context on this.

To demonstrate the issue, I took the screen recording below. In the recording, I am clicking in between the blog posts. The scroll to the top each time is automatic.

mobile-click-handling-issue

netlify[bot] commented 1 year ago

Deploy Preview for eleventy-excellent ready!

Name Link
Latest commit 6c5ce147dd51f136f163d6ecc29438a14619c0ea
Latest deploy log https://app.netlify.com/sites/eleventy-excellent/deploys/6433fc975719ba00086fccdc
Deploy Preview https://deploy-preview-9--eleventy-excellent.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

madrilene commented 1 year ago

Thank you! :)