search

madrobby / scripty2

scripty2: for a more delicious web
http://scripty2.com/
Other
516 stars 57 forks source link

Autocomplete on HTML5 inputs (emails, tel, ...) #34

Open ZenCocoon opened 12 years ago

ZenCocoon commented 12 years ago

Hi,

Wishing to add autocomplete support on the new HTML5 input types, like email, tel, ..., I realized that it's blocked to "text" types so far : https://github.com/madrobby/scripty2/blob/master/src/ui/controls/autocompleter.js#L23

I guess the main goal being to avoid "submit" types right? Would you consider the following selector input:not([type="submit"]) proper as a replacement ?

Hoping that helps, Best regards,

rafalwrzeszcz commented 12 years ago

Not only that - you would have to exclude also "reset", "hidden", "radio", "checkbox", "button" and probably some other types also.

ZenCocoon commented 12 years ago

That's a good point, there's actually way more that would not make sense (datetime, range, ...), thanks for pointing that out.

It's then better to pick only the potential ones then. What would you think of allowing the following types : text, email, tel, url, search

rafalwrzeszcz commented 12 years ago

I think this is exacly what we need.

ZenCocoon commented 12 years ago

The following selector works but wonder if something cleaner would exist ?

input[type="text"],input[type="email"],input[type="tel"],input[type="url"],input[type="search"]