search

madrobby / scripty2

scripty2: for a more delicious web
http://scripty2.com/
Other
516 stars 57 forks source link

Dialog no transmit "memo" var with the "ui:dialog:before:close" event #9

Open capripot opened 14 years ago

capripot commented 14 years ago

there is no "memo" var when you capture the "ui:dialog:before:close" event.

it can be fixed with a copy/paste the line memo, before the element.fire "ui:dialog:before:close"

var memo = { dialog: this, success: success };

and replace 

var result = this.element.fire("ui:dialog:before:close", {dialog: this);

with var result = this.element.fire("ui:dialog:before:close", memo);

thx a lot for the fix

justinbaker999 commented 13 years ago

...? What ?

Is this even an issue?

capripot commented 13 years ago

Yes this is still an issue.

justinbaker999 commented 13 years ago

I couldn't reproduce this. I got the memo var using this code https://gist.github.com/7cb1aa3cdcec59517abc