Open sgentle opened 12 years ago
+1 for this. I'm not sure how to deal with the amount of code that comes with this library. I mean… is it really necessary. It would be cool to include this makefile as it helps all users of this library.
Just make sure not to include a gzipped version.
semicolon.js
: 1 bytesemicolon.js.gz
: 34 bytesPlease consider adding a note to the README, encouraging semicolon.js users not to serve the library with HTTP compression enabled.
@mathiasbynens Indeed, one of the main reasons we recommend inlining the library code.
Hi Thomas,
I'm concerned about the performance implications of semicolon.js. I represent an early-stage revolutionary social enterprise. We're unconventional, ballsy, and poised to take over the peer-to-peer DIY freemium social location web app marketing mobile collaborative bookmark sphere. We're big fans of semicolon.js! Unfortunately, any significant increase to our page load time could completely compromise our vision and leave our investors -- and, ultimately, the world -- much worse off.
To this end, I'd like for you to accept our pull request, including a minified version of semicolon.js and a Makefile for generating it. In our testing, it has performed over 300% faster, and 500% faster when gzipped. This represents a significant investment of our rockninja developers' time (and therefore money) into this project, so if you could add our name to your list of sponsors that would be awesome.
I'd also like to take this opportunity to point out that not accepting this pull request might cause our business significant undue hardship. I've been told not to get into specifics, but let's just say this: you know what's cooler than not being sued for a million dollars? Not being sued for a billion dollars.
Cheers,
Sam