search

madsbangh / EasyButtons

Add buttons to your inspector in Unity super easily with this simple attribute
MIT License
1.08k stars 83 forks source link

Make EasyButtons a package manager package #13

Closed madsbangh closed 4 years ago

madsbangh commented 5 years ago

Unity Docs for custom packages

rfadeev commented 5 years ago

Hi, I can work on this, but first would like to know repository structure you want to have. Options include single master branch which is package itself or two branches master and upm with master branch being Unity project and upm branch being package only.

Example of single branch branch: https://github.com/Unity-Harry/Unity-AssetDependencyGraph Example of two branches: https://github.com/mob-sakai/UpmGitExtension

madsbangh commented 5 years ago

Thank you so much! That would be really appreciated.

I have to admit I don't know enough about UPM to make that decision. What would you recommend? As far as I understand, having a separate branch will work fine as long as it is appended to the url when adding it to a project's dependencies. I am however tempted to keep it simple and just use one branch, if the structure of the repository changes too drastically.

Are there any other pros and cons we should consider?

And again, thank you for your contributions :)

rfadeev commented 5 years ago

Currently repository is a Unity project hence structure would change indeed if use single branch support. While single branch looks more simple, from another perspective package development can become more complicated as you should have Unity project somewhere else with package repository cloned somewhere under Assets folder.

So both approaches have pros and cons. For my repositories I used single branch and bumped into issue with samples (see post on Unity forum) so now I'm also considering using two branches strategy (but did not try yet). For two branches strategy ideally need to automate push to package branch. Maybe for this project it's not critical as it's not actively developing.

madsbangh commented 5 years ago

If 2 branches could be a fun exercise for you, then I'd say go for it :) the repo is quite small, so I think it would be a perfect testbed - especially considering how rare updates are

rfadeev commented 5 years ago

One more thing before starting 2 branches approach. I assume github allows pull request to single branch only. In that case new branch should be created in the repository first so I can submit pull request to it (actually it will be two pull requests - master branch first and package branch later).

madsbangh commented 5 years ago

Sure thing :) let me know when to create the upm branch

madsbangh commented 5 years ago

I have created the branch 13-unity-package-manager-support based on current master. I hope this is what you need :) otherwise let me know.

madsbangh commented 5 years ago

Accidentally hit "Close and comment" instead of "Comment" 🥇

rfadeev commented 5 years ago

No worries.

I've already created 13-unity-package-manager-support (see https://github.com/rfadeev/EasyButtons/commits/13-unity-package-manager-support) and plan is following:

  1. Once 13-unity-package-manager-support is ready, open pull request to master
  2. Once pull request is merged, open next one targeting upm branch. At that moment content of upm branch should be generated automatically / semi-automatically. I'm thinking over how to do that at the moment.
github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: