search

madscatt / zazzie

development branch
GNU General Public License v3.0
2 stars 3 forks source link

MMC Overlap extension needs tests #187

Open madscatt opened 4 weeks ago

madscatt commented 4 weeks ago

Make sure input data types are correct and write a test.py script to test. Compare results to python 2.7 version. Related to issue #186

madscatt commented 4 weeks ago

Created a unittest. The extension seems to work as expected. Unclear what the issue is with #186.

madscatt commented 4 weeks ago

Okay, the overlap.c file has a type check:

    /*if (PyArray_TYPE(array) != NPY_FLOAT) {
        PyErr_SetString(PyExc_TypeError, "array must contain floats");
        return NULL;
    }*/

that should be modified so that it works.