search

madscientist / msjnc

MadScientist Juniper Network Connect Session Manager
MIT License
69 stars 20 forks source link

Problem with realms containing whitespace #2

Closed gdubya closed 11 years ago

gdubya commented 11 years ago

Our realm has a whitespace (e.g. "Normal Users"). This is passed to the ncsvc without quotes, and so it fails to connect.

madscientist commented 11 years ago

Hi. I checked the code and we definitely allow whitespace in realm names. In the Perl implementation I use the multi-argument form of exec(), which actually doesn't use a shell at all and instead invokes the command directly. Thus there are no quoting or whitespace issues. I've created a test environment where I can see exactly what arguments are being passed to the Juniper system and using a realm containing whitespace, the whitespace is properly preserved.

Can you provide more details about how you determined that this was the issue, and what your failure case was?

gdubya commented 11 years ago

Hi, apologies for taking so long to get back to you on this. I cannot remember the exact details of the problem anymore. If you cannot reproduce the problem then I probably made a mistake elsewhere and jumped to the wrong conclusion. I'll close this issue.