search

madscientistone / socialauth-net

Automatically exported from code.google.com/p/socialauth-net
0 stars 0 forks source link

When LoginCallback encounters an error, the redirect URL is invalid #174

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. In Brickred.SocialAuth.NET.Core.BusinessObjects.SocialAuthUser.LoginCallback
2. If the LoginCallback fails, it'll it is caught by the exception handler.
3. ex.Message is added as query parameter, but it usually contains newline 
characters.
4. Redirect will raise an ArgumentException: Redirect URI cannot contain 
newline characters. Stack trace:
[ArgumentException: Redirect URI cannot contain newline characters.]
   System.Web.HttpResponse.Redirect(String url, Boolean endResponse, Boolean permanent) +227
   System.Web.HttpResponse.Redirect(String url) +40
   Brickred.SocialAuth.NET.Core.BusinessObjects.SocialAuthUser.LoginCallback(String response) +415
   Brickred.SocialAuth.NET.Core.CallbackHandler.ProcessRequest(HttpContext context) +997
   System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +1132
   System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +114

When debugging, the actual url starts with:
"http://localhost:16588//User/Team/InviteFriends?error_message=Invalid Request 
Token received.\r\nProvider returned:"

Expected:
I expected a (correct) redirect to the error URL.

Version:
2.3.0.0

Original issue reported on code.google.com by fm0...@gmail.com on 5 Jun 2013 at 10:20

GoogleCodeExporter commented 9 years ago 
Note that this error masks the actual raised error in Issue 166: Google 
authentication doesn't return a token.

Original comment by fm0...@gmail.com on 10 Jun 2013 at 1:58

GoogleCodeExporter commented 9 years ago 
This is already resolved in 2.3.1 patch.

Deepak

Original comment by deepak.a...@3pillarglobal.com on 12 Jun 2013 at 9:24