madsen-lab / valiDrops

16 stars 5 forks source link

sparse->dense coercion warnings #6

Closed rrydbirk closed 1 year ago

rrydbirk commented 1 year ago

Running valiDrops(), I get several warnings for sparse-to-dense coercions. I traced it to these lines. However, scry::devianceFeatureSelection accepts sparse matrices.

https://github.com/madsen-lab/valiDrops/blob/803e6e5be0e94feced633ba3a0ac70f25f935bf3/R/expression_metrics.R#L69

https://github.com/madsen-lab/valiDrops/blob/8b7736ad070afe537a7f79e3d24a9bbeddae5c4b/R/label_dead.R#L166