search

madsen / vbindiff

Visual Binary Diff (VBinDiff) displays files in hex & ASCII and can highlight the differences between 2 files
479 stars 52 forks source link

Please merge past pull requests #5

Open E3V3A opened 9 years ago

E3V3A commented 9 years ago

@madsen Can you please merge those past PR's? I love this tool and use it very often...

Also, would you have any experience on how well it works on a Linux based system? It's not very clear from your README how to do that. Finally, do you think it's possible to port this to Android?

mgorny commented 8 years ago

I'm afraid this project is abandoned, to the point I'm considering removing it from Gentoo. And that's very sad because I like it a lot and would love to see someone maintaining it again.

@nfllab, @laomaiweng, @hexluthor, @bgrainger, would any of you be interested in actively maintaining a full fork of vbindiff? In other words, reviewing and merging all the current pull requests, fixing issues, doing releases, etc.? If you did, I would happily switch Gentoo to your fork.

laomaiweng commented 8 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

Hi Michał,

I might be interested. Please give me a couple of weeks so I can look into it.

Quentin

On 2015-11-15 10:54, Michał Górny wrote:

I'm afraid this project is abandoned, to the point I'm considering removing it from Gentoo. And that's very sad because I like it a lot and would love to see someone maintaining it again.

@nfllab [1], @laomaiweng [2], @hexluthor [3], @bgrainger [4], would any of you be interested in actively maintaining a full fork of vbindiff? In other words, reviewing and merging all the current pull requests, fixing issues, doing releases, etc.? If you did, I would happily switch Gentoo to your fork. -----BEGIN PGP SIGNATURE----- Version: Mailvelope v1.2.3 Comment: https://www.mailvelope.com

wsFcBAEBCAAQBQJWSIduCRD/eb8nD1+RLAAAPaQP/jcMwnds9hgkxZq3+8lw vsvLiBCEzz2WL1BPDjio3ZlZdk+112TFFnootMN58DlORbFGisidiUuSCZAP TmzGZNi93qGBHytClPmgyfb27UoR/wY5vTX47MJjTutFSNw+0wwIVMxjklrD 1qYx2M56xxcRhSQ+7GW1ujGOT0XJQEKV14n+ot7Y0pnaPcTXx7RUNq2vxPJ7 TbFS52Hslo+A4XA9BFtCkrVaHAlCKNaw+H7bp11U7JgWAwnb6bnDD2QC89LM U6gEX6P9LzU8/AVrqJXSsS3IduJrmDIgFAhb0RBuz2827c61mXAAyioYUagJ YWjBXgpWEjiMwQEadWNBkpJKftDElgv1speu02dUeKv48p48wuIDWykkNi+W V+L6trW0y1a653y24R3ZkLUz18+HzXKCWikjwtbBKUsgjkQaySMiFC+9rSQC 9k3ElDuKQGeMRLCh30EQDr+5l81Fnu7XnNmY4Khy4ogVPkyIXjNziSaViaqr HtFYkUtGIwHLo14tREbDouznLLr+3S1v7a9oW5uHoXDvSYsYH2/6SnhcSeml HglrH85tMd9mSMv+ix77hJAZCWrObGhRahV9J1IPhtrDxZ9ZxunB/rpkaxJq BNSGvGFq8BUc6mhxpT0mvu30fAnlU4SdR+EHJvgoloVd7cQCy7YzmyI3h9ac n7JC =NPgS -----END PGP SIGNATURE-----

nfllab commented 8 years ago

I use this tool daily, but I don't really want to maintain it, sorry.

mrdudz commented 8 years ago

i merged all pending pull requests into a new repo here: https://github.com/mrdudz/vbindiff

rofl0r commented 7 years ago

@mrdudz are you intending to maintain that ? the job of a maintainer is not to merge everything. it is to critically look at patches and merge those that are perfectly ok, and request changes for those that aren't, or do those changes yourself. for example the 64 GB support patch is not OK. it uses an unportable function _strtoui64 that's windows-only and should be replaced with strtoull. also it changes the size of the buffer to be one less when he actually uses one byte more. it needs to be studied if that is correct but on the first glance it appears that it's not. to be able to detect such issues needs some skills in the used language that are above mediocre. it's also a maintainers job to make releases; i.e. proper release tarballs.

mrdudz commented 7 years ago

not sure what the question is - i have created my fork and applied the patches because it wouldnt work for me without them (and apparently others). the unportable function has been replaced, and i have made a release tarball too. (which is used for gentoo packaging now - which happens to be my distro of choice)

that said, i am not keen on being the maintainer - i just want to keep using this program.

rofl0r commented 7 years ago

the unportable function has been replaced, and i have made a release tarball too. (which is used for gentoo packaging now - which happens to be my distro of choice)

glad to hear. i'm asking because people here were looking for a maintainer and you just said that you merged everything together - which is not really solving the problem. and i've seen some taken-over projects where the new owner basically just clicks on every merge button with catastrophical results. also i have some improvements in mind; but not knowing where to file my PRs against is an unsatifsfying situation - i would probably prefer then to maintain it myself.

rofl0r commented 7 years ago

@mrdudz you merged both #3 and #4 which are both fixing the same thing. didn't you notice ??? PR #4 is way inferior to #3 but since you merged it later you overwrote the good patch with the bad one. that behaviour reminds me exactly of above mentioned "just click on all merge buttons".

mrdudz commented 7 years ago

sorry, i dont remember how this happened, perhaps there was a reason for it, perhaps not :) it works and doesn't crash anymore, thats good enough for me :)