search

madsflensted / elm-brunch

Brunch plugin to compile Elm code
MIT License
74 stars 31 forks source link

consoleErrors option to see compilation errors in the browser #27

Closed comboy closed 7 years ago

comboy commented 7 years ago

I've been using elm-brunch with phoenix, and even though the framework nicely reloads page on changes, in case of compilation errors, the old version is loaded and there isn't any clue in the browser window that something went wrong. So I needed to see both browser window and terminal to see what syntax error did I make this time.

With this change all compilation errors are visible directly in the browser window thanks to console.error. Not sure if the option naming is good, and also I'm not much of a node coder so if something can be done better, let me know.

If you don't think such change belongs to elm-brunch that's cool too, just let me know and I will stick to my fork, for me it speeds up development a lot.

edit: and I guess I forgot about adding some tests, I'll wait with them until the info if you want such feature at all

madsflensted commented 7 years ago

Hi @comboy, thanks for putting in the effort to make this PR, sorry for the delay in responding, I simply have not had the time.

If you can add a couple of test cases just to cover the bases that would be great.

Also do you know if the code will work on both Linux/Mac and Windows?

madsflensted commented 7 years ago

Closing as inactive