Elm 19 adaptation - Githubissues

madsflensted / elm-brunch

Brunch plugin to compile Elm code

MIT License

74 stars 31 forks source link

Elm 19 adaptation #45

Closed Voronchuk closed 5 years ago

Voronchuk commented 5 years ago

Removed mandatory --yes flag (not supported in Elm 19);
Made executable configurable by elmMake config option, elm make is now a default one, replace with elm-make --yes for Elm 18;
Added support for optimize: true flag for Elm 19.

madsflensted commented 5 years ago

Thank you for contributing! Could I get you to add tests for the 0.19/0.18 and optimize flag? And fix the existing tests with regards to the --yes parameter?

Voronchuk commented 5 years ago

I'll try if anyone is willing to help feel free to join.

John-Goff commented 5 years ago

Hi! I fixed the tests, and wrote some new ones for the new features. Couldn't figure out how to add the commits directly to this PR, so I opened another one (https://github.com/madsflensted/elm-brunch/pull/46). Sorry for the double PR, I'm still new to open source. If someone can tell me how to merge the two PRs I'll gladly close the other one.

madsflensted commented 5 years ago

@Voronchuk @John-Goff thank you both for the contribution. I have published the changes in 0.12.0

Voronchuk commented 5 years ago

Cool! @John-Goff thanks for fixing tests