search

madshutter / homework-landingpage

0 stars 0 forks source link

Feedback on assignment #2 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #2 Project: Styling with CSS

Description

A hot, new NY Tech Startup, Relaxr, has approached you to help them develop a new landing page for their company. They've handed you the design file for the site, along with the copy and assets. You need to take these files and turn it into a landing page.

Student: Madison Rosner

Project URL: https://github.com/madshutter/homework-landingpage
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a reset.css or normalize.css file in addition to your style.css file to style the page n/a n/a n/a
Use IDs and Classes to to select and style elements on the page x
Use at least two flex containers, each with at least two flex items x
Style your text with the Google Fonts provided by your style guide x
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 6/12
barryross commented 7 years ago

Hey Madison,

You are doing some great things here, and I also see some areas that I'd like to help clear up some possible confusion you may have.

The inline feedback will cover most of the above reasons for the missing marks, but for the flex requirement, the reason for the missing mark was that I was looking for two flex containers that had at least two flex items as children. I see section id="one" meets this requirement, but the rest only had one child flex item.

Please see inline comments for additional notes and reach out with any questions!

madshutter commented 7 years ago

Not sure why the .normalize file received a n/a score. It's linked in the html file. Please advise if I'm doing this incorrectly.

barryross commented 7 years ago

Oh, you did it great...I marked it n/a because I mentioned to the class that I wouldn't actually be grading that one b/c we hadn't covered the concepts until after I assigned the assignment..so I didn't think it would be fair of me