search

madsim-rs / madsim

Magical Deterministic Simulator for distributed systems in Rust.
Apache License 2.0
622 stars 41 forks source link

bump tonic version to v0.9 #151

Closed xxchan closed 12 months ago

xxchan commented 1 year ago

... I'm wondering whether we need to bump major version https://github.com/madsim-rs/madsim/issues/145

changelog: https://github.com/hyperium/tonic/blob/master/CHANGELOG.md

I mainly want this: build:: Support boxing fields

wangrunji0408 commented 1 year ago

... I'm wondering whether we need to bump major version https://github.com/madsim-rs/madsim/issues/145

I think it's needed. Tonic has breaking API change from 0.8 to 0.9.

xxchan commented 1 year ago

Oh, arrow-flight >= 37 also needs it. That's a larger need.

xxchan commented 1 year ago

Although I want to completely understand #153 and #145 first šŸ˜…

ZENOTME commented 1 year ago

Also needed in https://github.com/risingwavelabs/risingwave/pull/10875 for introducing Icelake.

xxchan commented 12 months ago

Iā€™m ok. Merge first to unblock work. I might need some more time to think about it, but we can fix problems later since we are 0.x šŸ¤£

On Thu, 20 Jul 2023 at 08:32, Runji Wang @.***> wrote:

@.**** approved this pull request.

Approve myself. :) @xxchan https://github.com/xxchan PTAL

ā€” Reply to this email directly, view it on GitHub https://github.com/madsim-rs/madsim/pull/151#pullrequestreview-1538527341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBQZNN7SZ4E4P7V4UY3IU3XRDGIBANCNFSM6AAAAAAZYJH5MU . You are receiving this because you were mentioned.Message ID: @.***>