Fix LevenbergMarquardt trace constructor to match Optim v0.5.

madsjulia / Mads.jl

MADS: Model Analysis & Decision Support

http://mads.gitlab.io

GNU General Public License v3.0

101 stars 20 forks source link

Fix LevenbergMarquardt trace constructor to match Optim v0.5. #2

Closed pkofod closed 8 years ago

pkofod commented 8 years ago

Ref: https://gist.github.com/anonymous/4609c24a5c7b8bb8222012c9564958c6 and https://github.com/JuliaLang/METADATA.jl/pull/5341

The way traces are initiated has changed a bit in Optim. I didn't notice you were accessing OptimizationTrace directly, so currently Mads.jl tests will fail in contamination.jl with Optim v0.5, because a trace cannot be initiated.

tkelman commented 8 years ago

Does this work with any earlier versions of Optim? If not, then best to set a lower bound of Optim 0.5 now for this change.

pkofod commented 8 years ago

Good point, changed.

coveralls commented 8 years ago

Changes Unknown when pulling bdc7f27a66cf789204b0bd5cf07355d27d8e1b55 on pkofod:master into \ on madsjulia:master**.

coveralls commented 8 years ago

Changes Unknown when pulling bdc7f27a66cf789204b0bd5cf07355d27d8e1b55 on pkofod:master into \ on madsjulia:master**.