search

madskjeldgaard / Birdhouse

An OSC to Midi Bridge. Cross-platform. VST, CLAP, Standalone.
Other
32 stars 1 forks source link

Error compiling on Windows with VS 17 2022: cannot convert from 'juce::var' to 'juce::String' #46

Closed giohappy closed 3 months ago

giohappy commented 3 months ago

This error is thrown everywhere a juve::var is converted to juce::String, e.g. here.

giohappy commented 3 months ago

It can be easily fixed by converting each juce::var to juce::String using the toString() method. After doing that I was able to build the plugin,

madskjeldgaard commented 3 months ago

Thanks for the issue and the fix. Could you be interested in doing the pull request with these fixes ?

Beat regards

giohappy commented 3 months ago

sure @madskjeldgaard I'll do it as soon as I'm back on it.

FYI I'm taking inspiration from you project and expand it with the following features:

Let's see how far I will get :)

madskjeldgaard commented 3 months ago

sure @madskjeldgaard I'll do it as soon as I'm back on it.

FYI I'm taking inspiration from you project and expand it with the following features:

  • make it accept any (valid) notes and cc. The idea is to have a sigle path accepting note numbers and cc values as parameters. They will be automatically forwarded, without having to map them, and without a limit of 8 paths
  • support timestamped OSC bundles, to be able to schedule midi messages at a given time in the future. This will also allow implementing external sequencers, which might lack accurate clocks. This is the same idea implemented by Supercollider, Sonic Pi, Tidalcycles, etc.

Let's see how far I will get :)

Great ideas!

I would need a bit more explanation of the first idea to fully understand what you're intending with it.

The second idea with time stamps is a big wish for me too, so if you want to create a PR for that at some point that would be sweet. Thanks for the feedback and help.

giohappy commented 3 months ago

I would need a bit more explanation of the first idea to fully understand what you're intending with it.

Let's focus only on midi notes. I suppose we could have a /midi path which accepts two interger params: the midi note (0-127) and the on/off value (0-1). This way you are not limited to the 8 fixed paths, which means 8 notes max (if you use them all for notes).

Maybe I miss something about you're implementation and this is already supported?

giohappy commented 3 months ago

@madskjeldgaard PR done https://github.com/madskjeldgaard/Birdhouse/pull/47

madskjeldgaard commented 3 months ago

Thanks a lot @giohappy !