search

madskjeldgaard / portedplugins

A collection of plugins for the SuperCollider sound environment, all of which are ported / remixed from elsewhere
GNU General Public License v3.0
180 stars 13 forks source link

CMake: several minor improvements #11

Closed mossheim closed 3 years ago

mossheim commented 3 years ago

See commit messages for rationale. I'm happy to discuss more if you have concerns/questions.

mossheim commented 3 years ago

btw, I couldn't reproduce that issue with DaisySP and -fpic locally with clang or gcc, so I wasn't able to confirm that it works. It is still not a good idea to set flags indiscriminately on all subprojects, though. Based on the error message which you pasted I am fairly confident this would still solve that error.

madskjeldgaard commented 3 years ago

btw, I couldn't reproduce that issue with DaisySP and -fpic locally with clang or gcc, so I wasn't able to confirm that it works. It is still not a good idea to set flags indiscriminately on all subprojects, though. Based on the error message which you pasted I am fairly confident this would still solve that error.

Hi Brian thanks for the PR. This is wonderful! I wasn't able to reproduce it either but solely experienced it when building in Github's Cloud using Github Actions.

I didn't know about the STRICT option - that's just great! I'll use that instead of my rudimentary hack here.

Thanks again!