madskjeldgaard / portedplugins

A collection of plugins for the SuperCollider sound environment, all of which are ported / remixed from elsewhere
GNU General Public License v3.0
180 stars 13 forks source link

VarShapeOsc & LockhartWavefolder not working on Win #25

Open ffforces opened 2 years ago

ffforces commented 2 years ago

The VarShapeOsc & Lockhart.. are not working on Win. Both are for some reason thinking that the folder structure should be /portedplugins/plugins not /portedplugins/classes. Also both are missing the help file as probably it's querying it from the wrong place.

madskjeldgaard commented 2 years ago

Sounds like a packaging error in the github actions file. Thanks for reporting

madskjeldgaard commented 2 years ago

Ah, so what you are referring to here is help file links? The package looks alright here. This is the contents for the windows zip file:

" zip.vim version v31
" Browsing zipfile /home/mads/Downloads/PortedPlugins-Windows.zip
" Select a file with cursor and press ENTER

AnalogBassDrum_scsynth.scx
AnalogBassDrum_supernova.scx
AnalogFoldOsc_scsynth.scx
AnalogFoldOsc_supernova.scx
AnalogPhaserMod_scsynth.scx
AnalogPhaserMod_supernova.scx
AnalogPhaser_scsynth.scx
AnalogPhaser_supernova.scx
AnalogSnareDrum_scsynth.scx
AnalogSnareDrum_supernova.scx
AnalogTape_scsynth.scx
AnalogTape_supernova.scx
AnalogVintageDistortion_scsynth.scx
AnalogVintageDistortion_supernova.scx
BLOsc_scsynth.scx
BLOsc_supernova.scx
Chen_scsynth.scx
Chen_supernova.scx
DCompressor_scsynth.scx
DCompressor_supernova.scx
HarmonicOsc_scsynth.scx
HarmonicOsc_supernova.scx
LockhartWavefolder_scsynth.scx
LockhartWavefolder_supernova.scx
LPG_scsynth.scx
LPG_supernova.scx
NeoFormant_scsynth.scx
NeoFormant_supernova.scx
NeoVarSawOsc_scsynth.scx
NeoVarSawOsc_supernova.scx
NonlinearFilter_scsynth.scx
NonlinearFilter_supernova.scx
OscBank_scsynth.scx
OscBank_supernova.scx
PhasorModal_scsynth.scx
PhasorModal_supernova.scx
Resonator_scsynth.scx
Resonator_supernova.scx
Rongs_scsynth.scx
Rongs_supernova.scx
StringVoice_scsynth.scx
StringVoice_supernova.scx
VA1Pole_scsynth.scx
VA1Pole_supernova.scx
VadimFilter_scsynth.scx
VadimFilter_supernova.scx
VADiodeFilter_scsynth.scx
VADiodeFilter_supernova.scx
VAKorg35_scsynth.scx
VAKorg35_supernova.scx
VALadder_scsynth.scx
VALadder_supernova.scx
VarShapeOsc_scsynth.scx
VarShapeOsc_supernova.scx
VASEM12_scsynth.scx
VASEM12_supernova.scx
VosimOsc_scsynth.scx
VosimOsc_supernova.scx
ZOsc_scsynth.scx
ZOsc_supernova.scx
Classes/
Classes/AnalogBassDrum.sc
Classes/AnalogFoldOsc.sc
Classes/AnalogPhaser.sc
Classes/AnalogPhaserMod.sc
Classes/AnalogSnareDrum.sc
Classes/AnalogTape.sc
Classes/AnalogVintageDistortion.sc
Classes/BLOsc.sc
Classes/Chen.sc
Classes/DCompressor.sc
Classes/HarmonicOsc.sc
Classes/LockhartWavefolder.sc
Classes/LPG.sc
Classes/NeoFormant.sc
Classes/NeoVarSawOsc.sc
Classes/NonlinearFilter.sc
Classes/OscBank.sc
Classes/PhasorModal.sc
Classes/Resonator.sc
Classes/Rongs.sc
Classes/StringVoice.sc
Classes/VA1Pole.sc
Classes/VadimFilter.sc
Classes/VADiodeFilter.sc
Classes/VAKorg35.sc
Classes/VALadder.sc
Classes/VarShapeOsc.sc
Classes/VASEM12.sc
Classes/VosimOsc.sc
Classes/ZOsc.sc
HelpSource/
HelpSource/Classes/
HelpSource/Classes/AnalogBassDrum.schelp
HelpSource/Classes/AnalogFoldOsc.schelp
HelpSource/Classes/AnalogPhaser.schelp
HelpSource/Classes/AnalogPhaserMod.schelp
HelpSource/Classes/AnalogSnareDrum.schelp
HelpSource/Classes/AnalogTape.schelp
HelpSource/Classes/AnalogVintageDistortion.schelp
HelpSource/Classes/BLOsc.schelp
HelpSource/Classes/Chen.schelp
HelpSource/Classes/DCompressor.schelp
HelpSource/Classes/HarmonicOsc.schelp
HelpSource/Classes/LockhartWavefolder.schelp
HelpSource/Classes/LPG.schelp
HelpSource/Classes/NeoFormant.schelp
HelpSource/Classes/NeoVarSawOsc.schelp
HelpSource/Classes/NonlinearFilter.schelp
HelpSource/Classes/OscBank.schelp
HelpSource/Classes/PhasorModal.schelp
HelpSource/Classes/Resonator.schelp
HelpSource/Classes/Rongs.schelp
HelpSource/Classes/StringVoice.schelp
HelpSource/Classes/VA1Pole.schelp
HelpSource/Classes/VadimFilter.schelp
HelpSource/Classes/VADiodeFilter.schelp
HelpSource/Classes/VAKorg35.schelp
HelpSource/Classes/VALadder.schelp
HelpSource/Classes/VarShapeOsc.schelp
HelpSource/Classes/VASEM12.schelp
HelpSource/Classes/VosimOsc.schelp
HelpSource/Classes/ZOsc.schelp
HelpSource/HelpSource/
HelpSource/HelpSource/Overview/
HelpSource/HelpSource/Overview/PortedPlugins.schelp
madskjeldgaard commented 2 years ago

I think I have to test this myself, I don't fully understand what the issue is or what the symptoms are

ffforces commented 2 years ago

The symptoms are: those plugins are not working at all.

No help files loading.

VarShapeOsc : UGen : AbstractFunction : ObjectExtensionExtension
(Undocumented class)
Source: VarShapeOsc.sc
Description
This class is missing documentation.

Class Methods...

If u search the help file of VarShapeOsc this comes up and you can't click the source link as it says that the VarShapeOsc should be in a /plugins folder. Instead it's not there. It's in /classes folder.

ffforces commented 2 years ago

Oh actually, it is just the help file that's not loading!

Now the actual plugin works. And I of course can navigate to helpfile folder manually and open it there.