search

madskjeldgaard / portedplugins

A collection of plugins for the SuperCollider sound environment, all of which are ported / remixed from elsewhere
GNU General Public License v3.0
180 stars 13 forks source link

add Fverb #35

Closed schollz closed 1 year ago

schollz commented 1 year ago

Hi @madskjeldgaard, I have one more for your repo - the Fverb from JP Cimalnado. It is converted from Faust, so if that is out of bounds for this repo, no problem. But I do find this to be one of the most incredible sounding reverbs encountered for SuperCollider.

madskjeldgaard commented 1 year ago

This looks great Schollz. Thanks for another contribution! I wonder if we should add some information about how it was converted. The SuperCollider architecture sometimes changes in Faust and it has an effect on the generated output of a fast command.

Maybe this should be added in the help file or something? Which command, which tool, which faust version etc ?

schollz commented 1 year ago

Great idea, will add!

schollz commented 1 year ago

I recompiled with the latest faust and added a script convert.sh with the method (using your faust2sc.py!).

This hasn't been tested on Windows. I have a Windows computer that I could use but I've never compiled SC code on Windows. Would you know of a tutorial for installing the SuperCollider toolchain on Windows?

Edit: Nevermind, I see you have a pipeline for generating the Windows files! So cool, I'll just use those instead of compiling them on my machine.

schollz commented 1 year ago

I saw that you updated the build - all is working well now with this! I just force pushed the changes to keep it from conflicting with the new version.

madskjeldgaard commented 1 year ago

Thanks @schollz this works really well and has nice docs and sounds fantastic. I'll merge it now. Thank for another great contribution!

schollz commented 1 year ago

Thanks @madskjeldgaard !! When you get a chance, would you post a release? Id like to share this one with my mac-based friends using the builds from the pipeline

madskjeldgaard commented 1 year ago

Sure!

On 22 Feb 2023, at 13:54, Zack @.***> wrote:

Thanks @madskjeldgaard https://github.com/madskjeldgaard !! When you get a chance, would you post a release? Id like to share this one with my mac-based friends using the builds from the pipeline

— Reply to this email directly, view it on GitHub https://github.com/madskjeldgaard/portedplugins/pull/35#issuecomment-1439971116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLO64B5JUQYAGJZE45GC73WYYEAXANCNFSM6AAAAAAU6G5IIE. You are receiving this because you were mentioned.