add M_E definition so DaisySP compiles with MSVC

madskjeldgaard / portedplugins

A collection of plugins for the SuperCollider sound environment, all of which are ported / remixed from elsewhere

GNU General Public License v3.0

180 stars 13 forks source link

add M_E definition so DaisySP compiles with MSVC #43

Closed sadguitarius closed 5 months ago

sadguitarius commented 6 months ago

Compilation was broken with MSVC since its math.h doesn't include math constants like GNU does, and the DaisySP ADSR need M_E defined. I just added the definition in CMakeLists.txt, but let me know if you think there's a better way. Thanks!

madskjeldgaard commented 5 months ago

Great find!

I think it would be better to have it in the constants file. Sorry this whole repo is a mess :-D https://github.com/madskjeldgaard/portedplugins/blob/main/plugins/constants.h

sadguitarius commented 5 months ago

Ah so it would be. I'll close this and open a new PR so the git history is clean. Thanks!

sadguitarius commented 5 months ago

New PR here: #44