search

madskjeldgaard / rofi-jack

Keyboard centric jack audio management using the rofi app launcher
9 stars 2 forks source link

FreeBSD package #1

Open mekanix opened 3 years ago

mekanix commented 3 years ago

First of all, I'm really grateful for your work! It looks amazing!

The thing with FreeBSD (I'm almost sure any other *nix except Linux) is that it places bash under /usr/local/bin. I just glanced the scripts in this repo and they don't seam like a bash specific ones, so I was wondering if you would be OK with using /bin/sh instead of /bin/bash? I would check it works, create PR and so on, I'm just curious if you would accept it? In the case I fail to make it POSIX compliant, would you mind if I send PR which uses "!/usr/bin/env bash" in the scripts?

In any case it would be nice to have a Makefile (I know how to write the one compatible with BSD and GNU implementation) that takes care of "make install". I can send that change in the PR, too, if you agree.

Anyway, as rofi and jack user, I can totally see the benefit of having this repo as FreeBSD port/package. Thank you again!

madskjeldgaard commented 3 years ago

Hi @mekanix That sounds awesome! I'd be happy to see a PR for this - as long as it doesn't break the Linux part of it. Thanks a lot !