Fix for crash on custom controls

madskristensen / DialToolsForVS

A Visual Studio extension

Other

50 stars 21 forks source link

Fix for crash on custom controls #24

Closed bjorndaniel closed 6 years ago

bjorndaniel commented 6 years ago

This PR fixes issue #23 by re-adding initialization of the commands available in the Custom Controls dialog. The function that initializes them had somehow gotten lost in a previous pr causing VS to crash when searching for commands.

xperiandri commented 6 years ago

With this code, I haven't opened the custom options

But my new pull has been tested and definitely works

bjorndaniel commented 6 years ago

I pulled xperiandri:beautify-cutom-options-page and there it crashes on search in Custom options. However I have no interest in arguing about this, I will abandon this PR and let Mads merge your version. If the crash is not there that is awesome, if it is I will just use my fork with the fix from above.