search

madskristensen / EditorColorPreview

Apache License 2.0
21 stars 5 forks source link

CSS files over the 10000 character limit #19

Open mattjmcguire opened 3 months ago

mattjmcguire commented 3 months ago

I've gotten a bit frustrated that the internal limit is set to 10000 characters to keep VS from "freezing up" while it parses the file. So i completely understand why that got put in there.

request: can we get this value as a editor setting somewhere?

the standard bootstrap min file is around: 160000+ characters, so theoretically if I just set this value somewhere slightly below this, it will still be able to color code my much smaller CSS files.

So for now I just pulled down the code and changed the limit to 150000 characters max, recompiled and reinstalled the extension.

I do really prefer this one to the other extension in keeping the editor simple. Thanks for this.

Screenshot 2024-08-27 145308

graymatter00 commented 3 months ago

@mattjmcguire Does this mean that the limit you are referring to is the cause of the bug discussed in #17? If yes, could you please consider making your altered version available for download?

mattjmcguire commented 3 months ago

that would be it for #17 it's in ColorAdornmentTagger.cs on line 22. I'll see what I can do for getting the altered version up.

mattjmcguire commented 3 months ago

I changed it and did a pull request (I believe) TBH my interaction with github is usually pretty limited to my own projects as basically as a private backup and versioning, so I hopefully did that correctly.

stamminator commented 1 month ago

Why does EditorColorPreview need to parse the entire file in the first place? Color highlighting should be possible by only parsing what's in the viewport, reprocessing as the user scrolls or changes the file contents. It would perform better and wouldn't care if the file is 10,000 characters or 10 million. I have to imagine that Visual Studio's API supports this.