Open jmarolf opened 3 years ago
@jmarolf @mikadumont Should the extension alert the users to uninstall it if they run 16.10 or newer, or is there a different way they can coexist, and both add value?
I would like it to work so I could delegate to your editor factory somehow if the user hits F6 (Open With) but I am not aware of a way to have editor factories become aware of each other like that? Do you know of a way?
I do not, but @gundermanc might know?
As a workaround, I just right-click the file and using "Open With", "Common Language Editor"
Out of curiosity, is the new EditorConfig editor in 16.10 based on Mads' code, or is it another case of NIH Syndrome even though Mads works at MSFT?
They have different goals. I want to eventually take Mads extension, but we also needed a UI view over editorconifg files to help people search and find the options they were looking for.
I actually installed the extension not to be forced into the UI every time I open an .editorconfig
file, because I'm not a fan of that UI.
@ffes Me too - I've had Mads' extension installed for over 2-3 years now and I didn't get to see VS' new .editorconfig
designer until now and... it's really disappointing. It's like the VS' Tools > Options > C# > Formatting settings page, but worse in every way: it doesn't show previews, it's still missing easily a third of the built-in Tools > Options settings, it doesn't have the naming-rules editor, and so on - and it uses a pointlessly enlarged UI font-size too for some reason, making it quite unpleasant to use overall.
Hands-down, Mads' extension is better - the only tad annoying thing is Mads' extension gives me warnings for editorconfig rules it doesn't recognize... which is a problem because the latest .NET SDK/Roslyn versions add more more rules which this extension doesn't recognize.
As a workaround, I just right-click the file and using "Open With", "Common Language Editor"
@Jehoel Using the instructions above, you can also mark "Common Language Editor" as the default and never see the UI again.
related: https://github.com/dotnet/roslyn/issues/52661
both the new Editorconfig UI in VS 16.10 and the extension in this repo register editor factories to handle the editorconfig file type
I see no way of fixing this on the roslyn side without extension co-operation. Today the editorconfig extension will always win due to ordering