Fix leaking temp files - Githubissues

madskristensen / ImageOptimizer

A Visual Studio extension

Other

163 stars 40 forks source link

Fix leaking temp files #5

Closed fritsduus closed 9 years ago

fritsduus commented 9 years ago

Hi Mads I had a lot of image files to compress and got an error because I ran out of available temp filenames. This Pull Request fixed the problem for me. Regards Frits

madskristensen commented 9 years ago

I think you missed a semicolon, so the PR doesn't compile

fritsduus commented 9 years ago

Yes, sorry its fixed now. Í am missing a project template and also the "$(VSToolsPath)\VSSDK\Microsoft.VsSDK.targets", so I had to hack the project file to make it build on my PC and then be careful not to commit these hacks.

fritsduus commented 9 years ago

Hmmm... looking over my commits again. We could also just go with my first commit. It is simpler and will perform better. Would you like me to change it back to that solution ?

madskristensen commented 9 years ago

Yeah, maybe close this PR and send a new one with the changes you want in?