madskristensen / MIDL

A Visual Studio extension
Apache License 2.0
24 stars 5 forks source link

Deleting base file right after calling merge service can break merge editor function #7

Closed roxk closed 1 year ago

roxk commented 2 years ago

Describe the bug In this line, base file is deleted after passing to the merge service. This can cause problem as the editor provides features such as compare with base file. Actually clicking compare with base file in IDL Merge would show dialog saying the base file doesn't exists.

To Reproduce Steps to reproduce the behavior:

  1. Right click any idle file and click update header file
  2. Click compare -> compare with base file
  3. See error dialog.

Expected behavior Can compare with base, no error dialog shown.

Screenshots image

Additional context Suggest the extension just leave the temp file alone, and purge 3-days-old files regularly. A solution to mitigate file bloat is to use the same file name as the idl so that repeatedly updating header file only generates one temporary.

roxk commented 1 year ago

Confirm this is fixed.